All these years Apple still has no way to share entire photo libraries with family. The shared family album is useful only to temporarily share the week’s photos. So I use PhotoSync iOS App to sync our iPhone photos to the NAS, files prefixed with first names, and then once a week manually import to the two libraries via macOS Photos. Works well enough but Photos has very poor dupe detection. Supposedly iOS detects dupes – I wish they would surface them in an aptly named album. Once imported, I use PhotoSync to mark the new imports on each device all as sync’d and then delete the week’s worth of shared photos from the family shared album. That’s two nearly exact copies of a 50 GB photo library stored in iCloud. We used to use Google Photos but decided they no longer deserved analyzing our lives.